On Wed, Mar 18, 2020 at 4:39 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Elijah Newren <newren@xxxxxxxxx> writes: > > > 4) Jonathan provided some good examples of cases where the > > --keep-cherry-pick behavior isn't just slow, but leads to actually > > wrong answers (a revert followed by an un-revert). > > That one cuts both ways, doesn't it? If your change that upstream > once thought was good (and got accepted) turned out to be bad and > they reverted, you do not want to blindly reapply it to break the > codebase again, and with the "drop duplicate" logic, it would lead > to a wrong answer silently. > > So from correctness point of view, I do not think you can make any > argument either way. Good point. Thanks, that helps.
