Hello Harshit, > I found a few test scripts where the 'test -f' can potentially be replaced by 'test_path_is_file' > function. That's nice! > I changed one test script and it works fine. So, should I > just commit this change now (the change looks very trivial to me) and > if not, how to proceed from here? Make sure to execute a 'make' in the working directory so that your changes _actually_ have some effect. Running a changed test without 'make' is basically running the old test all over again. You could also maybe do some code modernizations. What I did as my microproject might be of some help: https://lore.kernel.org/git/20200118083326.9643-1-shouryashukla.oo@xxxxxxxxx/ Also, make sure the commit message is descriptive and does not contain any extra whitespaces. I think you must know by now that we submit patches here via the mailing list and not pull requests. Regards, Shourya Shukla
