On Tue, Mar 17, 2020 at 4:40 PM Taylor Blau <me@xxxxxxxxxxxx> wrote:
> NB: this introduces an unfortunate possibility that attempt to write the
> ERR sideband will cause a SIGPIPE. This can be prevented by some of
> SZEDZER's previous work, but it is silenced in 't' for now.
s/SZEDZER/SZEDER/
> diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh
> @@ -235,6 +235,29 @@ test_expect_success 'implicitly construct combine: filter with repeated flags' '
> +test_expect_success 'upload-pack fails banned object filters' '
> + # Ensure that configuration keys are normalized by capitalizing
> + # "blob:None" below:
> + test_config -C srv.bare uploadpack.filter.blob:None.allow false &&
I found the wording of the comment more confusing than clarifying.
Perhaps rewriting it like this could help:
Test case-insensitivity by intentional use of "blob:None" rather than
"blob:none".
or something.
> + test_must_fail ok=sigpipe git clone --no-checkout --filter.blob:none \
> + "file://$(pwd)/srv.bare" pc3
> +'
