On 2020-03-15 19:20, Eric Sunshine wrote: > On Sun, Mar 15, 2020 at 2:09 PM Andrei Rybak <rybak.a.v@xxxxxxxxx> wrote: >> Add missing spaces before '&&' and switch tabs to spaces. Also fix the >> space after redirection operator in t3701-add-interactive.sh while we're >> here. These issues were found using `git grep '[^ ]&&$'`. >> >> Signed-off-by: Andrei Rybak <rybak.a.v@xxxxxxxxx> >> --- >> diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh >> @@ -348,7 +348,7 @@ test_expect_success \ >> - echo "To be changed and have mode changed" > 07-change-mode-change && >> + echo "To be changed and have mode changed" > 07-change-mode-change && > > The commit message talks about dropping whitespace after the '>' > redirection operator (and some of the changes in this patch do so), > however, this change neglects that cleanup. Good catch. t9500-gitweb-standalone-no-errors.sh has 35 of these vs 19 redirects with correct formatting, so it might be better to fix those redirects in a separate patch. What do you think? >> @@ -361,7 +361,7 @@ test_expect_success \ >> - echo "Changed and have mode changed" > 07-change-mode-change && >> + echo "Changed and have mode changed" > 07-change-mode-change && > > Ditto. > Thanks for review.
