Re: [PATCH v2] git-gui--askpass: coerce answers to UTF-8 on Windows

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/03/20 09:31PM, Johannes Schindelin via GitGitGadget wrote:
> From: Luke Bonanomi <lbonanomi@xxxxxxxxx>
> 
> This addresses the issue where Git for Windows asks the user for a
> password, no credential helper is available, and then Git fails to pick
> up non-ASCII characters from the Git GUI helper.
> 
> This can be verified e.g. via
> 
> 	echo host=http://abc.com |
> 	git -c credential.helper= credential fill
> 
> and then pasting some umlauts.
> 
> The underlying reason is that Git for Windows tries to communicate using
> the UTF-8 encoding no matter what the actual current code page is. So
> let's indulge Git for Windows and do use that encoding.
> 
> This fixes https://github.com/git-for-windows/git/issues/2215
> 
> Signed-off-by: Luke Bonanomi <lbonanomi@xxxxxxxxx>
> Helped-by: Junio C Hamano <gitster@xxxxxxxxx>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>

Merged. Thanks all.

-- 
Regards,
Pratyush Yadav



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux