>From Derrick Stolee, Thu 12 Mar 2020 at 14:28:11 (-0400) :
> I _think_ the t/tXXXX directories are used for this kind of data storage,
> so you could generate an empty multi-pack-index from an older version of
> Git then store it there.
Yes I anticipated that and have one available on hand :)
It weights 1116 characters.
> > - if (flags & MIDX_PROGRESS)
> > - progress = start_sparse_progress(_("Verifying OID order in multi-pack-index"),
> > - m->num_objects - 1);
> > - for (i = 0; i < m->num_objects - 1; i++) {
> > - struct object_id oid1, oid2;
> > + if (m->num_objects == 0)
> > + midx_report(_("Warning: the midx contains no oid."));
>
> Should this "Warning: " be here? The other calls to midx_report() do not have such prefix.
Right, I agree it should not.
> Also, it may be valuable to return from this block so you do not need to put the block below in a tabbed block, reducing the complexity of this patch.
Agreed: we don't want to run the other checks anyway if we don't have any
objects.
That'll be for v3 once I get advice on what to do for tests.
