Re: [PATCH v5 20/20] rebase: rename the two primary rebase backends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Junio C Hamano wrote:
> Elijah Newren <newren@xxxxxxxxx> writes:

>> I'm a little worried about ignoring the setting and just picking one;
>
> I am more than a little worried, too.  I think erroring out is
> warranted in this case for exactly the reason you gave here.

To avoid misunderstandings: have you read the proposal I made that aims
to avoid that problem?

Thanks,
Jonathan

>> if the setting has been marked and they set it to e.g. "appply" (one
>> too many p's), then does it really make sense to just show a warning
>> but continue using the backend they didn't want, especially since they
>> may miss the warning among the rest of the output?  I'd rather go the
>> route of improving the message, perhaps:
>>         _("Unknown rebase.backend config setting: %s")



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux