1. Jonathan N: An experience some folks have is, sending a patch and
hearing nothing. That must mean patch is awesome. But then realize I
need to do something to get a review. In Git, people like Peff are good
about responding to newcomers. As an author it can be hard to excite
people enough to review your patch. Relatedly, you might get a review,
but it doesn’t give you the feedback you wanted. As a reviewer, you
want to help people to grow and make progress quickly, but it might not
be easy to identify patches where this will be possible.
2. Emily: A few months ago we started doing code review book club. Git
devel IRC, and mailing list, could we be more public about these? I
queue my patch to list of things that have been idle and needs a review,
then a bot pops something off the list to increase attention for people
to review?
3. Jonathan Tan: during book club we discuss and review together.
Everyone can benefit from review experience and expertise. Emily is
hoping for similar knowledge transfer in the IRC channel.
4. Brian: general case that patches don’t get lost. There is the git
context script, but I am now a reviewer because I have touched
everything for SHA256. But we are losing patches and bug reports because
things get missed. What tool would we use? How would we do it?
5. Jonathan N: patchwork exists, need to learn how to use it :)
6. Peff: this is all possible on the mailing list. I see things that
look interesting, and have a to do folder. If someone replies, I’ll
take it off the list. Once a week go through all the items. I like the
book club idea, instead of it being ad hoc, or by me, a group of a few
people review the list in the queue. You might want to use a separate
tool, like IRC, but it would be good to have it bring it back to the
mailing list as a summary. Public inbox could be better, but someone
needs to write it. Maybe nerd snipe Eric?
7. Stolee: not just about doing reviews, but training reviewers.
