The ref-filter API does not correctly handle commit or tag messages that use CRLF as the line terminator. Such messages can be created with the--verbatim option of git commit and git tag, or by using git commit-tree directly. This impacts the output of git branch -v, and git branch, git tag and git for-each-ref when used with a --format argument containing the atoms %(contents:subject) or %(contents:body). The first patch in this series adds a new test library, t/lib-crlf-messages.sh, that contains functions to test this behaviour for commands using either the ref-filter or the pretty API to display messages. The second patch fixes the bug in ref-filter.c and adds corresponding tests. Finally, the third patch adds a test that checks the behaviour of git log in the presence of CRLF in messages, to prevent futur regressions. Philippe Blain (3): t: add lib-crlf-messages.sh for messages containing CRLF ref-filter: teach the API to correctly handle CRLF log: add tests for messages containing CRLF to t4202 ref-filter.c | 19 +++++++++-- t/lib-crlf-messages.sh | 73 ++++++++++++++++++++++++++++++++++++++++ t/t3203-branch-output.sh | 26 +++++++++++--- t/t4202-log.sh | 24 +++++++++++++ t/t6300-for-each-ref.sh | 5 +++ t/t7004-tag.sh | 7 ++++ 6 files changed, 147 insertions(+), 7 deletions(-) create mode 100644 t/lib-crlf-messages.sh base-commit: 076cbdcd739aeb33c1be87b73aebae5e43d7bcc5 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-576%2Fphil-blain%2Ffix-branch-verbose-crlf-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-576/phil-blain/fix-branch-verbose-crlf-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/576 -- gitgitgadget
