On Thu, Mar 5, 2020 at 5:18 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Heba Waly <heba.waly@xxxxxxxxx> writes: > > >> * hw/advise-ng (2020-03-02) 5 commits > >> - tag: use new advice API to check visibility > >> - SQUASH??? > > > > A local change that needs to be squashed? > > I often leave these changes that are based on what I suggested in my > review (or what somebody else suggested and I found sensible) as a > separate "SQUASH???" patch while queuing, when I can foresee myself > changing minds later (on the other hand, trivial typofixes etc. are > often squashed directly into the patches as I queue), so that these > can be removed easily. > > As such, if the original author agrees with the suggestion, it is OK > to include it in the next round (when the suggested change is small > enough, don't bother with "Helped-by"). It is OK to drop it from > the next round when the original author does not agree with the > suggestion, too, but it would be good to say why somewhere in the > discussion. > Got it, thanks Junio and Jonathan for your replies. Heba
