Re: [PATCH v2 2/2] stash: remove the stash.useBuiltin setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Gummerer <t.gummerer@xxxxxxxxx> writes:

> +	Unused configuration Variable.  Used in Git versions 2.22 to

s/Variable/variable/;

> +	2.26 as an escape hatch to enable the legacy shellscript
> +	implementation of rebase. Now the built-in rewrite of it in C
> +	is always used. Setting this will emit a warning, to alert any
> +	remaining users that setting this now does nothing.

I am a bit torn between "just document it here as a stale variable
that can safely be removed from your configuration, and do not warn"
and what you did here.  Even if we warn for a few releases, this
entry cannot be removed from the documentation for a lot longer
time, if ever, anyway.  It's not like having an extra entry that is
unused in the configuration file would hurt users, anyway, and it is
not obvious that the warning helps more than it disrupts them by
bugging users to remove it from their configuration file.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux