It is more efficient to first check for a file's extension against git-p4.largeFileExtensions before git-p4.largeFileCompressedThreshold because the latter test may trigger a costly compression task. Signed-off-by: Sam Hocevar <sam@xxxxxxxxxxx> --- git-p4.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git git-p4.py git-p4.py index 40d9e7c594..a54970aa74 100755 --- git-p4.py +++ git-p4.py @@ -1197,7 +1197,7 @@ def processContent(self, git_mode, relPath, contents): """Processes the content of git fast import. This method decides if a file is stored in the large file system and handles all necessary steps.""" - if self.exceedsLargeFileThreshold(relPath, contents) or self.hasLargeFileExtension(relPath): + if self.hasLargeFileExtension(relPath) or self.exceedsLargeFileThreshold(relPath, contents): contentTempFile = self.generateTempFile(contents) (pointer_git_mode, contents, localLargeFile) = self.generatePointer(contentTempFile) if pointer_git_mode: -- 2.25.1