On Wed, Feb 26, 2020 at 10:31 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > This change, and Brian's SHA-256 work, obviously will introduce a > conflict as the other side wants to add an extra parameter to choose > from different hash algorhtims. > > I wonder if we should rather add a single pointer to a struct that > can hold various initialization options as an extra parameter. That > way, each topic can add and manage its own new member in the struct. > > > static int create_default_files(const char *template_path, > > - const char *original_git_dir) > > + const char *original_git_dir, > > + const char *ref_storage_format, int flags) > > Pretty much the same story here, too. The other side aims to be > more generic and passes a "struct repository_format *" as an extra > parameter. Sounds great to me. Could we submit a patch that changes this into master already so Brian and can work on the same basis? > I am not sure how quickly Brian's SHA-256 work solidifies enough to > build on top of, but if it is a good option to build on top of the > topic, that may save some work from this topic, too, as the > mechanism to choose something (i.e. hash algorithm for Brian's > topic, ref backend for this topic) fundamental to the repository at > runtime and at initialization time needs similar supporting > infrastructure, such as changes in "[12/24] setup: allow > check_repository_format to read repository format", and "[13/24] > builtin/init-db: allow specifying hash algorithm on command line" > of that series. Can I pull this series as a git branch somewhere? -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
