On Tue, Feb 25, 2020 at 02:26:34PM -0800, Junio C Hamano wrote: > Emily Shaffer <emilyshaffer@xxxxxxxxxx> writes: > > > How about if I localize the bugreport template, headers, and formatted > > comments (e.g. "3745 local loose objects"), and include a tip in 'git > > help bugreport' suggesting that if it doesn't look right, maybe the user > > wants to run it with 'LANG= LANGUAGE= git bugreport' to ensure it > > actually gets generated? > > I think that will be what is going to happen anyway in the real > world. We'd spend a reasonable effort for localization (and I > personally am perfectly OK if the effort for the initial round is > "almost zero"), but make sure C-locale is left as an escape hatch. OK. > > > I had another thought, actually, that this is maybe semantically similar > > problem to the malformed config we discussed earlier in the review. Does > > it make sense to include some kind of --safemode flag to 'git' which > > asks it to not perform localization and not read configs? > > I suspect that "git --safemode" would always end up being buggy than > running "git" under LANG=C LC_ALL=C GIT_CONFIG=/dev/null or something > like that ;-) > > Wouldn't it defeat more than 30% of the value of the tool if we > do not read and report the contents of the configuration file(s)? If you mean "the tool" = "Git", I won't argue with you. But if you mean "the tool" = "git-bugreport", I'd say that 70% of the value of the tool is better than 0% because my config is broken and I don't know why or how. - Emily
