"Heba Waly via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Heba Waly <heba.waly@xxxxxxxxx> > > Following the new helpers added to the advice library, > replace the global variable check approach by the new > API calls The last paragraph of the proposed log message you had for [2/3] described that this step is just an example better than the above one, which would leave readers puzzled what our plans are for dozens of existing advise() calls. > + if (type == OBJ_TAG) > + advise_if_enabled(NESTED_TAG, _(message_advice_nested_tag), > + tag, object_ref); This is probably a good enough example why OBJ_TAG is a good name but NESTED_TAG is not---type could be something different from OBJ_TAG but the other possiblities are all OBJ_<object-type>. We want the advice types to have the same property.
