On Tue, Feb 25, 2020 at 11:11 AM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Mon, Feb 24, 2020 at 5:05 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > "Heba Waly via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > +test_expect_success 'advise should be printed when config variable is unset' ' > > > + test-tool advise "This is a piece of advice" 2>actual && > > > + test_i18ncmp expected actual > > > +' > > > > - Prepare the expected output inside test_expect_success block that > > uses it. > > - There should be no SP between a redirection operator and the > > filename. > > - Here-doc that does not use parameter expansion should use a > > quoted EOF marker. > > - The file that gets compared with "actual" is by convention called > > "expect", not "expected". > > > > test_expect_success 'advise should be printed when config variable is unset' ' > > Also, s/advise/advice/ in the test title. > > > cat >expect <<-\EOF && > > hint: ... > > hint: ... > > EOF > > test-tool advise "This is a piece of advice" 2>actual && > > test_i18ncmp expected actual > > ' > > s/expected/expect/ Noted, thank you. Heba
