Jeff King <peff@xxxxxxxx> writes: > On Sun, Feb 23, 2020 at 08:59:35PM -0500, Eric Sunshine wrote: > >> This code has been unused since fa099d2322 (worktree.c: kill parse_ref() >> in favor of refs_resolve_ref_unsafe(), 2017-04-24), so drop it. > > Looks obviously correct, unless we are depending on some side effect of > get_git_common_dir(). And if we are, then that should be fixed. ;) Heh, get_git_common_dir() could be implemented to have some "setup" kind of side effect for the first call to it, but what is removed is the second call ;-) Besides, the body of get_git_common_dir() is a mere three lines that does not have any side effect, so...
