On Thu, Feb 20, 2020 at 10:06:36PM -0800, Anthony Sottile wrote: > In the event of a `^C` while hook scripts are running, ensure that the > hook processes are cleaned up and do not become zombies. This also ensures > that upon `^C` execution is not handed back to the terminal until the > processes have been waited upon. If we assume that most people would prefer this "wait until the hook has died" behavior, I think this shouldn't have any unwanted secondary effects. I'm on the fence on whether it's what most people would want or not (I guess most people don't care either way, because their scripts don't ignore SIGINT). (Earlier in the thread, we discussed possibly swapping the order of the cleanup code and dropping the signal handler, which could have more unexpected effects, but that part isn't in this patch). -Peff
