On Thu, Feb 20, 2020 at 02:24:08AM +0000, brian m. carlson wrote: > This series introduces wildcard matching (that is, urlmatch support) for > credential config options, just like for the http options. This is > helpful in corporate environments where custom credentials should be > used across a wide variety of subdomains. > > Changes from v1: > * Add a variety of additional tests in patch 3. > * Switch to using the last matching config option for > credential.username like we do everywhere else. > * Use all matching config keys, as we did before. > * Skip calling git_default_config. > * Fix percent-encoding handling and add a function to handle that. Thanks, this addresses all of my concerns, and I'm really happy to see all the new tests covering various bits from our discussion. Really cleanly done. -Peff
