Hi Stolee, Thanks as always for collecting these. I always finds these emails very helpful. On Tue, Feb 18, 2020 at 07:46:03AM -0500, Derrick Stolee wrote: > Taylor Blau 5d5916fd builtin/commit-graph.c: support '--split[=<strategy>]' > commit-graph.c > 5d5916fd 1751) break; This 'break' line only changed indentation, so I don't think that this is new 'uncovered' code in my series, only that it got a little bit harder to trigger. It is interesting that this is uncovered, but I don't think that there's a huge sense of urgency to add tests to cover it. > Taylor Blau a599e2c9 builtin/commit-graph.c: introduce '--input=<source>' > builtin/commit-graph.c > a599e2c9 75) *to = 0; > a599e2c9 76) return 0; These seem more interesting to cover, but only marginally so. > a599e2c9 86) *to |= COMMIT_GRAPH_INPUT_APPEND; This one I think we could ignore, though, since the same behavior is triggered by simply '--append' instead of '--input=append'. We decided in [1] to Thanks, Taylor [1]: 846706e9-efe2-448d-67a3-a96638e9bcbc@xxxxxxxxx
