Re: [PATCH 1/3] log_ref_write() -- do not chomp reflog message at the first LF

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, 29 Jul 2007, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> 
> > It is not like the reflog messages have to be very verbose; they only have 
> > to give a hint what the commit was about, and the commit name is the 
> > important information.
> 
> I've considered it, but decided against it because:
> 
>  (1) I did not like the information lossage;
> 
>  (2) this is solely to help log messages coming from outside the
>      recommended convention, and having excess will not hurt the
>      normal usage;
> 
>  (3) it is not known if messages from outside the recommended
>      convention have enough information on its first line of the
>      first paragraph; the result of s/\n.*/.../ may not be
>      sufficient "hint";

Good catch.  Didn't think of that.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux