On Wed, Feb 19, 2020 at 5:13 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Yes, but the case that matters to _your_ use is sb->alloc == 0. You
> do not want to let a broken strbuf (presumably broken by changes
> other than your own) to pass, when you can detect it. And for that,
> paying attention to sb->len _might_ make sense, but then the check
> won't be
>
> if (sb->alloc < sb->len)
> make it mutable;
>
> you'd rather be writing something like
>
> if (!sb->alloc)
> make it mutable;
> else if (sb->alloc < sb->len)
> BUG("somebody fed a corrupt strbuf to me");
Ooh so what you meant, is that corrupt `strbuf`s need to be
anticipated even if they
don't make much sense. Smart.
