"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> +void put_u64(byte *out, uint64_t v)
> +{
> + int i = 0;
> + for (i = sizeof(uint64_t); i--;) {
> + out[i] = (byte)(v & 0xff);
> + v >>= 8;
> + }
> +}
This looks OK, but ...
> +int names_length(char **names)
> +{
> + int len = 0;
> + for (char **p = names; *p; p++) {
> + len++;
> + }
... this will break the build with some compiler options (see for
example https://travis-ci.org/git/git/jobs/651322628#L679). You
may also want to lose {braces} around a single-statement block.
The incremental change between v5 and v6, especially the reflog
expiration bit, looked sensible.
Thanks.
