Hi, On Sun, 29 Jul 2007, Jeff King wrote: > On Sun, Jul 29, 2007 at 01:04:13PM +0100, Johannes Schindelin wrote: > > > The idea is this: when "--quiet" was given, we do not output anything, and > > therefore do not have to recurse into the directories, because we already > > know that there are differences when a _tree_ is different. I do not > > remember all details of the "--quiet" implementation, but I think that it > > > > - exits early (as you said) > > > > - does not turn on "recursive" to avoid unnecessary work. > > OK, looking through the code, this works _sometimes_. If I say "git-diff > --quiet" then it will not recurse. If I say "git-diff -p --quiet" then > it will (even though we never show the -p output). That is expected behaviour. If you ask for it, it should be done (however silly it might be). > Since --quiet supersedes all output formats, I think it probably should > just clear the recursive option entirely. In which case rather than > special-casing quiet to avoid recursion in git-diff, we can simply turn > on recursion before parsing options (and it will get turned off > correctly by any diff options that need to do so). No. Just think about "git diff -p -w --quiet". In some cases it _has_ to recurse. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
