On Fri, Feb 14, 2020 at 09:32:08AM -0800, Junio C Hamano wrote:
> Emily Shaffer <emilyshaffer@xxxxxxxxxx> writes:
>
> > present(patch 9/15). This now uses POSIX character classes and {}
> > notation instead of + and has been tested on OSX; I'd love to hear if
>
> I'd rather not to see unnecessary uses of POSIX character classes.
>
> The interdiff of this step between the previous and this round looks
> to me more like "I used it, just because POSIX says I *can* use it",
> not "I did so because I needed to do, and it should be OK on POSIX
> platforms."
>
> Instead of overly long
>
> 's/^\([^[:blank:]]*\)[[:blank:]]\{1,\}annotate:bugreport\[include\].* ::$/ "\1",/p'
>
> just limiting ourselves to SP and saying
>
> 's/^\([^ ]*\) *annotate:bugreport\[include\].* ::$/ "\1",/p'
>
> would keep the result much easier to read, I would think.
That's fine by me. I find the [[:syntax:]] extremely ugly, but I was
worried about whether that was more portable somehow. Your proposal
seems fine to me.
- Emily
