On Fri, Feb 07, 2020 at 04:30:42PM +0100, SZEDER Gábor wrote: > On Wed, Feb 05, 2020 at 04:41:02PM -0800, Emily Shaffer wrote: > > diff --git a/Documentation/asciidoctor-extensions.rb b/Documentation/asciidoctor-extensions.rb > > index d906a00803..382bd8f6f4 100644 > > --- a/Documentation/asciidoctor-extensions.rb > > +++ b/Documentation/asciidoctor-extensions.rb > > @@ -37,6 +37,10 @@ module Git > > output = output.sub(/<\/refmeta>/, new_tags + "</refmeta>") > > end > > output > > + > > + class AnnotateProcessor < Asciidoctor::Extensions::InlineMacroProcessor > > + def process(parent, target, attrs) > > + "" > > This change breaks building the documentation with Asciidoctor v1.5.8: > > /home/travis/.rvm/rubies/ruby-2.5.3/lib/ruby/site_ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require': /home/travis/build/git/git/Documentation/asciidoctor-extensions.rb:41: class definition in method body (SyntaxError) > > ...xtensions::InlineMacroProcessor > > ... ^ > > /home/travis/build/git/git/Documentation/asciidoctor-extensions.rb:53: syntax error, unexpected end-of-input, expecting keyword_end > > > https://travis-ci.org/git/git/jobs/647093871#L1127 Done. It passes locally for me now if I run: USE_ASCIIDOCTOR=1 make doc Thanks for the heads up. - Emily
