On Thu, Feb 13, 2020 at 01:47:38PM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > - count_bitmap_commit_list(bitmap_git, &commit_count, NULL, NULL, NULL); > > + count_bitmap_commit_list(bitmap_git, &commit_count, > > + revs->tree_objects ? &tree_count : NULL, > > + revs->blob_objects ? &blob_count : NULL, > > + revs->tag_objects ? &tag_count : NULL); > > So count_bitmap_commit_list() has been prepared to count non-commits > already, but we are just starting to use that feature? > > Interesting. Yeah, it goes all the way back to fff42755ef (pack-bitmap: add support for bitmap indexes, 2013-12-21), but was never used for non-commits. I was pleasantly surprised that it actually worked. ;) -Peff
