Hi Junio, On Wed, Feb 12, 2020 at 10:19:14AM -0800, Junio C Hamano wrote: > Taylor Blau <me@xxxxxxxxxxxx> writes: > > > Attached is what I anticipate/hope to be the final reroll of my series > > to add new arguments to the 'git commit-graph write --split' flag to > > allow callers to force or prohibit the commit-graph machinery to merge > > multiple commit-graph layers. > > > > I was keeping an eye out for more discussion about whether or not these > > flags were acceptable by reviewers. Martin Ågren and Derrick Stolee have > > both chimed in that they seem OK. > > > > Since there hasn't been much more discussion in this thread, I replayed > > this series on top of 'tb/commit-graph-use-odb' (which was itself > > rebased on 'master'). I picked up a couple of ASCIIDoc changes along the > > way, and a range-diff is included below. > > I haven't had a chance to form an opinion on this topic, and will > let others comment on it first. > > This topic and the "changed paths bloom filter" topic obviously and > inevitably have trivial textual conflicts. When today's integration > result is pushed out in 6 hours or so, please see if the resolution > is reasonable in 'pu'. The resolution looks good to me, thanks. > Thanks. Thanks, Taylor