On Wed, Feb 12, 2020 at 11:46:31AM -0500, Eric Sunshine wrote: > On Wed, Feb 12, 2020 at 3:57 AM Mike Hommey <mh@xxxxxxxxxxxx> wrote: > > If I'm not mistaken in my reading of the various files involved, it > > looks like for some reason, building git on mac leads to using Apple > > Common Crypto for SHA1, rather than SHA1dc, which seems unfortunate. > > Is that really expected? > > There was a discussion on this topic a while back[1], and it does seem > that the behavior you describe is intentional[2]. That discussion predates SHA1dc, though. > > More generally, at this point, should anything > > other than SHA1dc be supported as a build option at all? > > The conclusion [2,3] was that it likely would make sense to drop > support for Apple's CommonCrypto altogether, although nobody has yet > stepped up to do the work. I wasn't explicit in my question, but I meant more broadly than Apple Common Crypto. There is still opt-in support for openssl sha1 and PPC sha1. Mike
