On Mon, Feb 10, 2020 at 02:55:28PM -0800, Emily Shaffer wrote: > I tend to disagree on both counts. I'd personally rather see something > like 'void advise_key(enum advice, char *format, ...)'. Yeah, I don't mind that at all. It's mutually exclusive with not making people add new enums when they want to add new advice types, but as you note we do get some code maintenance benefit by having the variables, even if _adding_ a new one is a slightly larger pain. -Peff
