Hi René,
On Mon, Feb 10, 2020 at 08:15:19AM +0100, René Scharfe wrote:
> handle_content_type() only cares about the value after "Content-Type: ";
> there is no need to insert that string for it.
>
> Suggested-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
> Signed-off-by: René Scharfe <l.s.r@xxxxxx>
> ---
> mailinfo.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mailinfo.c b/mailinfo.c
> index 543962d40c..402ef04dd1 100644
> --- a/mailinfo.c
> +++ b/mailinfo.c
> @@ -570,7 +570,6 @@ static int check_header(struct mailinfo *mi,
> len = strlen("Content-Type: ");
> strbuf_add(&sb, line->buf + len, line->len - len);
> decode_header(mi, &sb);
> - strbuf_insertstr(&sb, 0, "Content-Type: ");
This looks quite good to me. When I first looked, I was wondering if we
should have used 'skip_prefix' and passed that result into
'strbuf_insertstr', but I think that's a bigger change than we need for
now.
This looks all right to me.
> handle_content_type(mi, &sb);
> ret = 1;
> goto check_header_out;
> --
> 2.25.0
Here is my:
Reviewed-by: Taylor Blau <me@xxxxxxxxxxxx>
Thanks,
Taylor
