Alexandr Miloslavskiy <alexandr.miloslavskiy@xxxxxxxxxxx> writes: > Sorry for late reply, I was on vacation. Now I'm back and ready to > continue :) > > Thanks for your review! > > On 21.01.2020 20:36, Junio C Hamano wrote: >>> Decisions taken for simplicity: >>> 1) It is not allowed to pass pathspec in both args and file. >>> >>> `if (!argc)` block was adapted to work with --pathspec-from-file. For >>> that, I also had to parse pathspec earlier. Now it happens before >>> `read_cache()` / `hold_locked_index()` / `setup_work_tree()`, which >>> sounds fine to me. >> >> That is not an explanation nor justification. > > I'm not exactly sure what are you suggesting. I expected that the proposed log message to explain and justify why a change (in behaviour, in design, etc.) is made. "There is this limitation" is not a justification---"because of such and such reasons, there is this limitation, otherwise such and such bad things happen" is.
