Hi René, El lun., 10 feb. 2020 a las 16:43, René Scharfe (<l.s.r@xxxxxx>) escribió: > > Hello Miriam, > > did you remove the Git mailing list from cc: intentionally? No, no. Maybe I clicked reply, instead reply all. Sorry. It is included in CC now. > > Am 10.02.20 um 12:16 schrieb Miriam R.: > > El dom., 9 feb. 2020 a las 10:59, Miriam R. (<mirucam@xxxxxxxxx>) escribió: > >> El sáb., 8 feb. 2020 a las 11:55, René Scharfe (<l.s.r@xxxxxx>) escribió: > >>> And if yes: locate_in_PATH() splits PATH by colon. That means it > >>> doesn't work on Windows, where the paths are separated by semicolons. > >>> exists_in_PATH() wraps it, so it shares that limitation. Wouldn't that > >>> cause issues for your use? > >> > >> Thank you, for point that out. I will check this. > > > > This function is used only to test if gitk exists. But as gitk does not work > > on Windows, then I think it is all ok because the evaluation is going to > > return false and nothing has to be changed. > > Now I'm confused, because I do use gitk on Windows. The third > screenshot on https://gitforwindows.org/ shows it as well, so you don't > have to just take my word on it. Ohh, as I'm not a Windows user, and after some google searches it seems to me it doesn't. It is clear that I was not asking the correct things, hehe. Thank you for the clarification. > > > Also, as this patch is not really needed for this part1, I will move > > it to the upcoming patch series. > > That makes sense. > > I guess it's to used in the C equivalent of the Shell function > bisect_visualize(), which resolves gitk using type, calls it if it's > found and falls back to git log if it isn't. Exactly. >Why not try to exec gitk > and fall back to git log if that fails? > It seems a good solution for me :) Thank you for reviewing. Best, Miriam. > René
