On 2/7/2020 11:15 AM, SZEDER Gábor wrote: > On Fri, Feb 07, 2020 at 10:36:58AM -0500, Derrick Stolee wrote: >> On 2/7/2020 10:09 AM, Garima Singh wrote: >>> >>> On 2/7/2020 8:52 AM, SZEDER Gábor wrote: >>>>> * Added unit tests for the bloom filter computation layer >>>> >>>> This fails on big endian, e.g. in Travis CI's s390x build: >>>> >>>> https://travis-ci.org/szeder/git-cooking-topics-for-travis-ci/jobs/647253022#L2210 >>>> >>>> (The link highlights the failure, but I'm afraid your browser won't >>>> jump there right away; you'll have to click on the print-test-failures >>>> fold at the bottom, and scroll down a bit...) >>>> >>> >>> Thank you so much for running this pipeline and pointing out the error! >>> >>> We will carefully review our interactions with the binary data and >>> hopefully solve this in the next version. >> >> Szeder, >> >> Thanks so much for running this test. We don't have access to a big endian >> machine right now, so could you please apply this patch and re-run your tests? > > Unfortunately, it still failed: > > https://travis-ci.org/szeder/git-cooking-topics-for-travis-ci/jobs/647395554#L2204 Thanks! Both fail on test 2 of t0095-bloom.sh, which includes this expected output line: Filter_Data:508928809087080a|8a7648210804001|4089824400951000|841ab310098051a8| We may not be properly adjusting the output in the test-helper. I still think the fixup patch I included is a good idea, but Garima continues to dig into the problem from all angles to understand this failure and the full fix. -Stolee
