Am 05.02.20 um 17:45 schrieb Andrei Rybak: > Hi René, > > On 2020-02-04 22:14, René Scharfe wrote: >> This code was moved straight out of name_rev(). As such, we inherited >> the "goto" to jump from an if into an else-if. We also inherited the >> fact that "nothing to do -- return NULL" is handled last. >> >> Rewrite the function to first handle the "nothing to do" case. Then we >> can handle the conditional allocation early before going on to populate >> the struct. No need for goto-ing. >> >> Signed-off-by: Martin Ågren <martin.agren@xxxxxxxxx> >> --- >> Original submission: >> https://lore.kernel.org/git/20190922081846.14452-1-martin.agren@xxxxxxxxx/ > > Judging by this sign-off, link to Martin's email, and shortlog from the cover letter ... > >> Martin Ågren (1): >> name-rev: rewrite create_or_update_name() > > ... it seems that "From: Martin Ågren <martin.agren@xxxxxxxxx>" is missing. Yes, indeed. Sorry for that. :( René
