On Tue, Feb 04, 2020 at 09:00:23PM -0500, Derrick Stolee wrote: > On 2/4/2020 4:14 PM, René Scharfe wrote: > > This code was moved straight out of name_rev(). As such, we inherited > > the "goto" to jump from an if into an else-if. We also inherited the > > fact that "nothing to do -- return NULL" is handled last. > > > > Rewrite the function to first handle the "nothing to do" case. Then we > > can handle the conditional allocation early before going on to populate > > the struct. No need for goto-ing. > > I read this carefully and agree it is functionally equivalent. As did I. I originally thought that my MUA was wrapping the 'else if' line oddly, but then I discovered that it's the label's indentation that was throwing me off. In any case, this makes good sense. Well done indeed. > Since you are removing a goto and rearranging if/else blocks, I thought > this response needed to be explicit, at least more than usual. Good work. > > Thanks, > -Stolee Thanks, Taylor
