Re: [PATCH v2 2/5] commit-graph.h: store an odb in 'struct write_commit_graph_context'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Taylor Blau <me@xxxxxxxxxxxx> writes:

> On Tue, Feb 04, 2020 at 11:54:58AM -0800, Junio C Hamano wrote:
>> Taylor Blau <me@xxxxxxxxxxxx> writes:
>>
>> > Whoops. In v2, this patch introduces 'find_odb()' as a function in
>> > 'builtin/commit-graph.c', but does not declare it static. This causes
>> > breakage in gcc with '-Wmissing-prototypes'. Here is a correct version
>> > of the patch that does not cause such breakage.
>> >
>> > -- 8< --
>> >
>> > Subject: [PATCH v2 2/5] commit-graph.h: store an odb in 'struct
>>
>> What happened to the rest of the line ;-)?
>
> Heh. Your email made me chuckle since this wasn't the first time I've
> been asked about this today ;-). I manually yanked the 'Subject:' line,
> but not the continuation below it.
>
> I'd be happy to re-send a version of this patch to fix this, but if you
> don't mind slicing it up, that works too.
>
> Thanks,
> Taylor

Noneedtoresend. Thanks.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux