On Thu, 30 Jan 2020 at 13:35, Luke Diamand <luke@xxxxxxxxxxx> wrote: > > On Fri, 24 Jan 2020 at 20:14, Luke Diamand <luke@xxxxxxxxxxx> wrote: > > > > On Fri, 17 Jan 2020 at 22:00, Yang Zhao <yang.zhao@xxxxxxxxxxxxxx> wrote: > > > > > > On Fri, Dec 13, 2019 at 3:53 PM Yang Zhao <yang.zhao@xxxxxxxxxxxxxx> wrote: > > > > This patchset adds python3 compatibility to git-p4. > > > > > > Ping? One very small bug report: When doing "git p4 sync" it prints out the percent complete. It looks like it's no longer rounding it sensibly, so where before it would say 77%, now it says 77.7777777%. It's this line: sys.stdout.write("\rImporting revision %s (%s%%)" % (change, cnt * 100 / len(changes))) I think / just needs replacing with //. > > > > Hi! > > > > Sorry, I've been a bit busy. > > > > I quickly tried this and it was failing for me with: > > > > > failure accessing depot: could not connect > > > > It works fine with the interpreter set to /usr/bin/python, but > > changing it to python3 caused this problem. > > > > I'm at 050387ce43179f1b0da364dd6eec10ce578d6583. > > I'm using it for day-to-day work, so far it's working well, thanks!