On Sun, Feb 02, 2020 at 08:36:46PM -0800, Taylor Blau wrote: > That all said, I am not sure that I follow the explanation that we need > to have 'write_commit_graph_ctx' store the normalized object_dir, since > we can use 'odb->path' for this instead. I double checked, and we > already do the same loose normalization in > 'sha1-file.c:link_alt_odb_entry()', where we remove trailing slashes. I was assuming that the normalization in write_commit_graph_ctx was necessary (and I think there are some tests around this), but I admit I didn't actually try it. If it's not failing tests, I'm OK with comparing the non-normalized paths as an intermediate step, since we end up comparing pointers after the final patches. -Peff
