On Fri, Jan 31, 2020 at 01:37:44PM +0100, Johannes Schindelin wrote: > If my reading is correct, and we want `git diff-files --color` to respect > the `diff.wsErrorHighlight` setting, then this patch fixes that: > [...] > The bigger question is whether other core developers agree with this? And > what other `diff.*` settings should be respected by `git diff-files` (and > of course, `git diff-index`)? I think you can take my posting of an identical patch elsewhere in the thread as a "yes". :) -Peff