On Thu, Jan 30, 2020 at 12:12:47PM -0800, Taylor Blau wrote: > > @@ -1077,6 +1077,8 @@ const char *remove_leading_path(const char *in, const char *prefix) > > > > /* > > * It is okay if dst == src, but they should not overlap otherwise. > > + * The "dst" buffer must be at least as long as "src"; normalizing may shrink > > + * the size of the path, but will never grow it. > > Thanks for documenting this. It's quite helpful, and hopefully should > prevent bugs like the one you alluded to in your cover letter from > getting in in the future. To be picky, I didn't find an actual bug around buffer lengths; the problem was a failure to check the error code. This was just something I happened to find confusing auditing the code. -Peff
