Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Jonathan Tan wrote: > >> If a filter is specified, we do not need a full connectivity check on >> the contents of the packfile we just fetched; we only need to check that >> the objects referenced are promisor objects. >> >> This significantly speeds up fetches into repositories that have many >> promisor objects, because during the connectivity check, all promisor >> objects are enumerated (to mark them UNINTERESTING), and that takes a >> significant amount of time. >> >> Signed-off-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx> >> --- >> For example, a local fetch was sped up from 6.63s to 3.39s. The bulk of >> the remaining time is spent in yet another connectivity check >> (fetch_refs -> check_exist_and_connected) prior to the fetch - that will >> hopefully be done in a subsequent patch. > > Can this information (at least the speedup) be included in the comment > message? > > Or even better, can we demonstrate the impact using a perf test? It does make sense, but let's queue these two first and then add it as a follow-up patch on top. Thanks for writing and reviewing.
