git-p4 handles most errors by calling die(). This can leave child
processes still running, orphaned.
https://public-inbox.org/git/20190227094926.GE19739@xxxxxxxxxx/
This is not a problem for humans, but for CI, it is.
This change improves things by raising an exception and cleaning up
further up the stack, rather than simply calling die().
This is only done in a few places, such that the tests pass with the changes
suggested in the link (adding sleep strategically) but there are still
plenty of places where git-p4 calls die().
This also adds some pylint disables, so that we can start to run pylint
on git-p4.
Luke Diamand (6):
git-p4: make closeStreams() idempotent
git-p4: add P4CommandException to report errors talking to Perforce
git-p4: disable some pylint warnings, to get pylint output to
something manageable
git-p4: create helper function importRevisions()
git-p4: cleanup better on error exit
git-p4: check for access to remote host earlier
git-p4.py | 180 +++++++++++++++++++++++++++++++++---------------------
1 file changed, 109 insertions(+), 71 deletions(-)
--
2.20.1.390.gb5101f9297
