Hi,
On Fri, 27 Jul 2007, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
>
> > diff --git a/path.c b/path.c
> > index c4ce962..0f7012f 100644
> > --- a/path.c
> > +++ b/path.c
> > @@ -292,3 +292,65 @@ int adjust_shared_perm(const char *path)
> > return -2;
> > return 0;
> > }
> > +
> > +/* We allow "recursive" symbolic links. Only within reason, though. */
> > +#define MAXDEPTH 5
> > +
> > +const char *make_absolute_path(const char *path)
> > +{
> > + static char bufs[2][PATH_MAX + 1], *buf = bufs[0], *next_buf = bufs[1];
> > + char cwd[1024] = "";
> > + int buf_index = 1, len;
> > +
> > + int depth = MAXDEPTH;
> > + char *last_elem = NULL;
> > + struct stat st;
> > +
> > + if (strlcpy(buf, path, PATH_MAX) >= PATH_MAX)
> > + die ("Too long path: %.*s", 60, path);
> > +
> > + while (depth--) {
> > + if (stat(buf, &st) || !S_ISDIR(st.st_mode)) {
> > + char *last_slash = strrchr(buf, '/');
> > + *last_slash = '\0';
> > + last_elem = xstrdup(last_slash + 1);
>
> What happens when incoming path is just "abc"? Does your test
> script checks that case?
No, and you already guessed it: there will be a segmentation fault.
Will fix.
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
