From: Emily Shaffer <emilyshaffer@xxxxxxxxxx>
The number of unpacked objects in a user's repository may help us
understand the root of the problem they're seeing, especially if a
command is running unusually slowly.
Helped-by: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
Signed-off-by: Emily Shaffer <emilyshaffer@xxxxxxxxxx>
---
The refactor removed much of the code Dscho suggested; and yet it
remains true that he helped me while developing this commit (although
his suggestions didn't survive). Shall I leave the Helped-by line or
remove it?
- Emily
bugreport.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
diff --git a/bugreport.c b/bugreport.c
index 4c77009f1b..bf10857183 100644
--- a/bugreport.c
+++ b/bugreport.c
@@ -10,6 +10,7 @@
#include "bugreport-config-safelist.h"
#include "khash.h"
#include "run-command.h"
+#include "object-store.h"
static void get_curl_version_info(struct strbuf *curl_info)
{
@@ -171,6 +172,48 @@ static void get_populated_hooks(struct strbuf *hook_info, int nongit)
}
}
+static int loose_object_cb(const struct object_id *oid, const char *path,
+ void *data) {
+ int *loose_object_count = data;
+
+ if (loose_object_count) {
+ (*loose_object_count)++;
+ return 0;
+ }
+
+ return 1;
+}
+
+static void get_loose_object_summary(struct strbuf *obj_info) {
+
+ int local_loose_object_count = 0, total_loose_object_count = 0;
+ int local_count_questionable = 0, total_count_questionable = 0;
+
+ local_count_questionable = for_each_loose_object(
+ loose_object_cb,
+ &local_loose_object_count,
+ FOR_EACH_OBJECT_LOCAL_ONLY);
+
+ total_count_questionable = for_each_loose_object(
+ loose_object_cb,
+ &total_loose_object_count,
+ 0);
+
+ strbuf_addf(obj_info, "%d local loose objects%s\n",
+ local_loose_object_count,
+ local_count_questionable ? " (problem during count)" : "");
+
+ strbuf_addf(obj_info, "%d alternate loose objects%s\n",
+ total_loose_object_count - local_loose_object_count,
+ (local_count_questionable || total_count_questionable)
+ ? " (problem during count)"
+ : "");
+
+ strbuf_addf(obj_info, "%d total loose objects%s\n",
+ total_loose_object_count,
+ total_count_questionable ? " (problem during count)" : "");
+}
+
static const char * const bugreport_usage[] = {
N_("git bugreport [-o|--output <file>]"),
NULL
@@ -246,6 +289,9 @@ int cmd_main(int argc, const char **argv)
get_header(&buffer, "Configured Hooks");
get_populated_hooks(&buffer, nongit_ok);
+ get_header(&buffer, "Loose Object Counts");
+ get_loose_object_summary(&buffer);
+
report = fopen_for_writing(report_path.buf);
strbuf_write(&buffer, report);
fclose(report);
--
2.25.0.341.g760bfbb309-goog
