Hi, Martin
On Thu, Jan 23, 2020 at 5:28 PM Martin Ågren <martin.agren@xxxxxxxxx> wrote:
>
> Hi Matheus,
>
> On Thu, 23 Jan 2020 at 20:02, Matheus Tavares <matheus.bernardino@xxxxxx> wrote:
> > In af09ce2 ("sparse-checkout: init and set in cone mode", 2019-11-21),
> > the '--cone' option was added to 'git sparse-checkout init'. Add this
> > option to the respective doc file.
>
> Nit: s/respective/corresponding/
>
> "Respective" sounds -- to me at least -- like you're tweaking two
> different files. Maybe that's just me.
>
> > To avoid interfering with other worktrees, it first enables the
> > `extensions.worktreeConfig` setting and makes sure to set the
> > `core.sparseCheckout` setting in the worktree-specific config file.
> > ++
> > +When `--cone` is provided the `core.sparseCheckoutCone` setting is also
>
> Nit: maybe add a comma after "provided". Without it, I could see someone
> false-starting the parsing as "provided with the" or even "provided to
> the". Those readings obviously don't work out in the end, but with an
> extra comma, I think it's easier to just naturally read this the way
> it's intended.
>
> > +set, allowing for better performance with a limited set of patterns
> > +(see 'CONE PATTERN SET' bellow).
>
> s/bellow/below/
Thanks for the comments. Junio has already addressed them[1] when
picking up the patch :)
[1]: https://github.com/gitster/git/commit/a402723e488c66bd12cf674c332f185fee1d2347
