On Thu, Jan 23, 2020 at 11:20:36AM -0800, Junio C Hamano wrote: > -- >8 -- > Subject: [PATCH] gitk: be prepared to be run in a bare repository Thanks all for cleaning up the mess I caused. I do prefer adjusting gitk like this rather than reverting the change in Git. Despite the regression, I think the case of "--show-toplevel without a working tree" is sufficiently undefined that it's probably good for callers to actually decide what the right behavior is. > Recent versions of git however notices that "rev-parse --show-toplevel" > executed in a bare repository is an error, which makes gitk stop, > even before the user could attempt to run external diff. It might be worth mentioning 2d92ab32 by name in this paragraph of the commit message. -Peff
