Re: [PATCH v3 2/2] t6025: use helpers to replace test -f <path>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 2/2] t6025: use helpers to replace test -f <path>
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Tue, 21 Jan 2020 13:58:11 -0800
Cc: sunshine@xxxxxxxxxxxxx, git@xxxxxxxxxxxxxxx, johannes.schindelin@xxxxxx
In-reply-to: <20200118083326.9643-7-shouryashukla.oo@gmail.com> (Shourya Shukla's message of "Sat, 18 Jan 2020 14:03:26 +0530")
References: <CAPig+cQX=jB1KTKcOMVE9u0jX-ZXt_vQBndkzqqQWORu5iFxeA@mail.gmail.com> <20200118083326.9643-1-shouryashukla.oo@gmail.com> <20200118083326.9643-7-shouryashukla.oo@gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Shourya Shukla <shouryashukla.oo@xxxxxxxxx> writes:

> Take advantage of helper function 'test_path_is_file()' to
> replace 'test -f' since the function makes the code more
> readable and gives better error messages.

Looks good.  Thanks.

References:
- Re: [PATCH 2/3] t6025: replace pipe with redirection operator
  - From: Eric Sunshine
- [PATCH 0/3] t6025: updating tests
  - From: Shourya Shukla
- [PATCH v3 2/2] t6025: use helpers to replace test -f <path>
  - From: Shourya Shukla

Prev by Date: Re: [PATCH v3 1/2] t6025: modernize style
Next by Date: Re: [PATCH] submodule.c: mark more strings for translation
Previous by thread: [PATCH v3 2/2] t6025: use helpers to replace test -f <path>
Next by thread: [PATCH 3/3] t6025: use helpers to replace test -f <path>
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux