On Sat, Jan 18, 2020 at 9:51 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Please downcase Refactor; that way this change would not
> meaninglessly stand out in the "git shortlog --no-merges" output.
Sure, no problem.
> The blank before your sign-off means all the times spent gets
> discarded, which is not exactly encouraging to the reviewers.
So I should make a better description for the patch? Sure! What
should I put? It's kind of hard to get a good description that
describes the refactoring without digging into the reasoning behind
it, which is in the follow-up patch. What kind of description should
I give? How about like this:
color.c: refactor color_output arguments
color_output() now uses a more descriptive "background" argument
instead of "type".
Signed-off-by: Eyal Soha <shawarmakarma@xxxxxxxxx>
Suits?
