Hi Eric, On Mon, 20 Jan 2020, Eric Sunshine wrote: > On Mon, Jan 20, 2020 at 3:04 PM Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > On Mon, 20 Jan 2020, Eric Sunshine wrote: > > > On Fri, Jan 17, 2020 at 6:38 PM Johannes Schindelin via GitGitGadget > > > <gitgitgadget@xxxxxxxxx> wrote: > > > > + test $colliding_sha1 = "$(git rev-parse HEAD | cut -c 1-7)" && > > > > > > How much do we care that this is introducing new code with git > > > upstream of a pipe (considering recent efforts to eradicate such > > > usage)? Same question regarding several other new instances introduce > > > by this patch. > > > > I would argue that the test case will fail if the `git` call fails. So I > > am not overly concerned if that `git` call is upstream of a pipe. > > Unless the git command crashes _after_ it produces the correct output... Yes, that is true. In a very hypothetical way, of course. :-) Ciao, Dscho
